Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmstudio pull model #999

Merged
merged 3 commits into from
Jan 12, 2025
Merged

lmstudio pull model #999

merged 3 commits into from
Jan 12, 2025

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Jan 11, 2025


Here's a high-level summary of the changes in the GIT_DIFF in a way that a software engineer will understand:

  • A new function OpenAIListModels has been added to list the available models from OpenAI.
  • The existing pullModel function and transcriber function have been moved to separate functions named OpenAIPullModel and OpenAITranscribe, respectively. This refactoring helps to organize the code better and make the functions more reusable.
  • Various changes have been made to the public API in "packages/core/src/prompt_template.d.ts" and "packages/core/src/prompt_type.ts". These changes are "user-facing" because they affect how users interact with the software.

AI-generated content by pr-describe may be incorrect

Copy link

Investigator report

, ce0e8ef

AI-generated content by gai may be incorrect

Copy link

LGTM 🚀

The PR adds support for pulling models from a new provider (LMU) by implementing the missing pullModel function. The code looks solid and follows the existing patterns. No functional issues are apparent.

If there is any additional cleanup or refactoring needed, let me know. Otherwise, I'll approve this PR!

AI-generated content by pr-review may be incorrect

@pelikhan pelikhan merged commit 90c0645 into main Jan 12, 2025
14 checks passed
@pelikhan pelikhan deleted the lmstudiosdk branch January 12, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant